-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated tokens #4560
Remove deprecated tokens #4560
Conversation
Storybook staging is available at https://kiwicom-orbit-dsil-remove-deprecated-tokens.surge.sh |
Size Change: -3.72 kB (-0.8%) Total Size: 459 kB
ℹ️ View Unchanged
|
25b15bc
to
b0b4b07
Compare
Deploying orbit with Cloudflare Pages
|
c1da587
to
b0e19b7
Compare
b269466
to
bf701e3
Compare
d809ae8
to
cfbb3ff
Compare
BREAKING CHANGE: deprecated elevation prop values were removed.
BREAKING CHANGE: deprecated borderRadius prop values were removed.
BREAKING CHANGE: deprecated margin and padding prop values were removed.
BREAKING CHANGE: deprecated spacing prop values were removed.
BREAKING CHANGE: deprecated spacing prop values were removed.
BREAKING CHANGE: deprecated sideOffset prop values were removed.
BREAKING CHANGE: deprecated spacing prop values were removed.
BREAKING CHANGE: deprecated spacing prop values were removed.
BREAKING CHANGE: deprecated spacing prop values were removed.
BREAKING CHANGE: tokens no longer start with `widthBreakpoint-`. They're now simply `breakpoint-`
BREAKING CHANGE: these classes were deprecated and not meant to be used.
BREAKING CHANGE: these classes were deprecated and not meant to be used.
cfbb3ff
to
a106a44
Compare
Is there any explanation for these changes? I would have expected to rely on visual tests for this kind of huge PRs |
They were prior to this PR tbh. I can remove them and the pipeline will still go all green. These are local snapshots and the disadvantages of not using docker to run the tests locally 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup 😅 🧹
Went through all the commits although not super thoroughly as I mainly rely on the integration tools and the token/class usage breaks + visual tests.
packages/orbit-tailwind-preset/src/__tests__/__snapshots__/configs.test.ts.snap
Show resolved
Hide resolved
...ltip-primitive-visual-tests-screenshot-for-default---various-placements-1-Desktop-darwin.png
Outdated
Show resolved
Hide resolved
docs/src/documentation/05-development/04-migration-guides/01-v19.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/05-development/04-migration-guides/01-v19.mdx
Outdated
Show resolved
Hide resolved
Ok ok, that's enough for me, didn't know that. |
BREAKING CHANGE: the separator size classes were deprecated and not meant to be used.
BREAKING CHANGE: this class was not meant to be used.
BREAKING CHANGE: these classes were deprecated and not meant to be used.
BREAKING CHANGE: these classes were not meant to be used.
BREAKING CHANGE: these classes were deprecated and not meant to be used.
BREAKING CHANGE: these classes were deprecated and not meant to be used.
BREAKING CHANGE: these classes were deprecated and are not meant to be used.
BREAKING CHANGE: these classes were deprecated and are not meant to be used.
BREAKING CHANGE: these classes were deprecated and are not meant to be used.
BREAKING CHANGE: these classes were deprecated. New number level classes can be used.
BREAKING CHANGE: these functions were deprecated and are now removed.
BREAKING CHANGE: deprecated tokens were removed. They were not expected to be used anywhere by now. Check the diff for the full list and possible alternatives.
a106a44
to
2c2682c
Compare
This PR tackles the following, in order:
left
andright
util functions (Breaking changes) — extra scope but change is minimalA full review of the tokens documentation will be done on a separate task.
The migration guide does not list the complete set of tokens and tailwind classes removed because:
Therefore, this migration guide highlights just the most relevant changes.
Per commit review advised!
FEPLT-2081