Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stacktrace sending when stack_info is enabled (#87) #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions structlog_sentry/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@

from sentry_sdk import Hub
from sentry_sdk.integrations.logging import _IGNORED_LOGGERS
from sentry_sdk.utils import capture_internal_exceptions, event_from_exception
from sentry_sdk.utils import (
capture_internal_exceptions,
event_from_exception,
current_stacktrace,
)
from structlog.types import EventDict, ExcInfo, WrappedLogger


Expand Down Expand Up @@ -121,10 +125,31 @@ def _get_event_and_hint(self, event_dict: EventDict) -> tuple[dict, dict]:
if has_exc_info:
client = self._get_hub().client
options: dict[str, Any] = client.options if client else {}
event, hint = event_from_exception(
exc_info,
client_options=options,
)

# if the stack_info field is set utilize the internal sentry capture function to send out the exception
# with the stack trace. Ref: https://github.com/kiwicom/structlog-sentry/issues/87
if event_dict.get("stack_info", False):
event, hint = {}, {}
with capture_internal_exceptions():
event["threads"] = {
"values": [
{
"stacktrace": current_stacktrace(
include_local_variables=options[
"include_local_variables"
],
max_value_length=options["max_value_length"],
),
"crashed": False,
"current": True,
}
]
}
else:
event, hint = event_from_exception(
exc_info,
client_options=options,
)
else:
event, hint = {}, {}

Expand Down
Loading