This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
feat: add useApiTokenAuth config #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 12, 2021 11:31
This enables us to switch on/off authentication for the graphql backend as on production we use Googles IAP
batisteo
reviewed
Feb 12, 2021
|
This pull request introduces 1 alert when merging fb6a91f into d8f041d - view on LGTM.com new alerts:
|
|
Kudos, SonarCloud Quality Gate passed!
|
batisteo
suggested changes
Feb 15, 2021
| @@ -1,6 +1,7 @@ | |||
| app: | |||
| title: Hangar App | |||
| baseUrl: http://localhost:3000 | |||
| useApiTokenAuth: false | |||
There was a problem hiding this comment.
Does it work for you? It seems like we’d need to change the schema of the config somewhere.
Anyway, it doesn’t pick the config when I’m trying locally 😕
There was a problem hiding this comment.
I still have to successfully run this locally.
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to switch on/off authentication for the
graphql backend as on production we use Googles IAP