This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
WIP: Entity model (Sourcery refactored) #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-6
to
+14
| if data["kind"] == "component": | ||
| if data["spec"]["type"] == "service": | ||
| self._build_service(data) | ||
| elif data["spec"]["spec"] == "library": | ||
| self._build_library(data) | ||
| else: | ||
| self._build_base_component(data) | ||
| else: | ||
| if data["kind"] != "component": | ||
| return NotImplemented | ||
|
|
||
| if data["spec"]["type"] == "service": | ||
| self._build_service(data) | ||
| elif data["spec"]["spec"] == "library": | ||
| self._build_library(data) | ||
| else: | ||
| self._build_base_component(data) |
There was a problem hiding this comment.
Function EntityBuilder.entity refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #405 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
jaro/entity_modelbranch, then run:Help us improve this pull request!