Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade helm version in deploy job #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

horakihor
Copy link
Contributor

@horakihor horakihor commented Oct 19, 2023

What this PR does / why we need it:

This PR upgraded the helm chart docker image to support Helm 3 charts in this repo.

Which issue this PR fixes

  • It fixes errors in the GitHub Actions
+ helm package /github/workspace/charts/graphite --destination /github/workspace/kiwigrid.github.io
building graphite chart...
Error: apiVersion 'v2' is not valid. The value must be "v1"

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped (if the pr is an update to an existing chart)
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

@horakihor
Copy link
Contributor Author

Hey @rpahli, it looks like the deploy job has been broken for a few months already (https://github.com/kiwigrid/helm-charts/actions/runs/6571196491/job/17849889050), as some of the charts are only helm3 comparable. This should fit it. Could you please review this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant