Skip to content

Commit

Permalink
Refactor mail notifier in Journal class
Browse files Browse the repository at this point in the history
  • Loading branch information
ewilan-riviere committed Feb 2, 2024
1 parent e2aaf34 commit 98cef82
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,10 @@ jobs:
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick, fileinfo
coverage: pcov

- uses: JarvusInnovations/background-action@v1
name: Setup mailpit
with:
run: |
sudo bash < <(curl -sL https://raw.githubusercontent.com/axllent/mailpit/develop/install.sh)
mailpit
- name: Setup mailpit
run: |
sudo bash < <(curl -sL https://raw.githubusercontent.com/axllent/mailpit/develop/install.sh)
mailpit
- name: Setup problem matchers
run: |
Expand Down
1 change: 0 additions & 1 deletion phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ parameters:
paths:
- src
- config
- database
tmpDir: build/phpstan
checkOctaneCompatibility: true
checkModelProperties: true
Expand Down
2 changes: 1 addition & 1 deletion src/Journal.php
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public function toDatabase(Model|Authenticatable|Collection|array|null $users =
public function notifier(string $type): self
{
$this->notifier = match ($type) {
'mail' => Notifier::mail()->auto(),
'mail' => Notifier::mail(),
'slack' => Notifier::slack(config('steward.slack.webhook')),
'discord' => Notifier::discord(config('steward.discord.webhook')),
default => null,
Expand Down

0 comments on commit 98cef82

Please sign in to comment.