Refactor code to use null instead of an empty array in getImage() method

composer.json

@@ -1,7 +1,7 @@
 {
     "name": "kiwilan/php-tmdb",
     "description": "PHP wrapper package to interact with the The Movie Database (TMDB) API.",
-    "version": "0.0.33",
+    "version": "0.0.34",
     "keywords": [
         "php",
         "tmdb",

src/Models/TmdbModel.php

@@ -21,10 +21,14 @@ protected function validateData(?array $data, string $key, Closure $closure): mi
         return null;
     }
 
-    protected function loopOn(mixed $values, string $class): ?array
+    protected function loopOn(mixed $values, string $class, bool $nullAsDefault = true): ?array
     {
         if (! $values) {
-            return null;
+            if ($nullAsDefault) {
+                return null;
+            } else {
+                return [];
+            }
         }
 
         $items = [];
@@ -49,7 +53,7 @@ protected function toBool(array $data, string $key, bool $default = false): bool
         return $value ? boolval($value) : $default;
     }
 
-    protected function toInt(array $data, string $key, ?int $default = null): ?int
+    protected function toInt(?array $data, string $key, ?int $default = null): ?int
     {
         $value = $data[$key] ?? null;
 

src/Results/CollectionResults.php

@@ -11,7 +11,7 @@ public function __construct(array $data)
     {
         parent::__construct($data);
 
-        $this->results = $this->loopOn($data['results'] ?? null, \Kiwilan\Tmdb\Models\Collection::class);
+        $this->results = $this->loopOn($data['results'] ?? [], \Kiwilan\Tmdb\Models\Collection::class, false);
     }
 
     public function getFirstResult(): ?\Kiwilan\Tmdb\Models\Collection

src/Results/MediaResults.php

@@ -11,7 +11,7 @@ public function __construct(array $data)
     {
         parent::__construct($data);
 
-        $this->results = $this->loopOn($data['results'] ?? null, \Kiwilan\Tmdb\Models\Media::class);
+        $this->results = $this->loopOn($data['results'] ?? [], \Kiwilan\Tmdb\Models\Media::class, false);
     }
 
     public function getFirstResult(): ?\Kiwilan\Tmdb\Models\Media

src/Results/MovieDateResults.php

@@ -13,7 +13,7 @@ public function __construct(array $data)
         parent::__construct($data);
 
         $this->dates = new ResultsDates($data['dates'] ?? null);
-        $this->results = $this->loopOn($data['results'] ?? null, \Kiwilan\Tmdb\Models\Movie::class);
+        $this->results = $this->loopOn($data['results'] ?? [], \Kiwilan\Tmdb\Models\Movie::class, false);
     }
 
     public function getDates(): ?ResultsDates

src/Results/MovieResults.php

@@ -5,13 +5,13 @@
 class MovieResults extends Results
 {
     /** @var \Kiwilan\Tmdb\Models\Movie[] */
-    protected array $results = [];
+    protected ?array $results = [];
 
-    public function __construct(array $data)
+    public function __construct(?array $data)
     {
         parent::__construct($data);
 
-        $this->results = $this->loopOn($data['results'] ?? null, \Kiwilan\Tmdb\Models\Movie::class);
+        $this->results = $this->loopOn($data['results'] ?? [], \Kiwilan\Tmdb\Models\Movie::class, false);
     }
 
     public function getFirstResult(): ?\Kiwilan\Tmdb\Models\Movie

src/Results/PeopleResults.php

@@ -11,7 +11,7 @@ public function __construct(array $data)
     {
         parent::__construct($data);
 
-        $this->results = $this->loopOn($data['results'] ?? null, \Kiwilan\Tmdb\Models\Credits\Person::class);
+        $this->results = $this->loopOn($data['results'] ?? [], \Kiwilan\Tmdb\Models\Credits\Person::class, false);
     }
 
     public function getFirstResult(): ?\Kiwilan\Tmdb\Models\Credits\Person

src/Results/Results.php

@@ -12,7 +12,7 @@ abstract class Results extends TmdbModel
 
     protected int $total_results;
 
-    public function __construct(array $data)
+    public function __construct(?array $data)
     {
         $this->page = $this->toInt($data, 'page', 1);
         $this->total_pages = $this->toInt($data, 'total_pages', 1);

src/Results/TvSerieResults.php

@@ -7,11 +7,11 @@ class TvSerieResults extends Results
     /** @var \Kiwilan\Tmdb\Models\TvSeries[] */
     protected array $results = [];
 
-    public function __construct(array $data)
+    public function __construct(?array $data)
     {
         parent::__construct($data);
 
-        $this->results = $this->loopOn($data['results'] ?? null, \Kiwilan\Tmdb\Models\TvSeries::class);
+        $this->results = $this->loopOn($data['results'] ?? [], \Kiwilan\Tmdb\Models\TvSeries::class, false);
     }
 
     public function getFirstResult(): ?\Kiwilan\Tmdb\Models\TvSeries

tests/Movie/MovieSearchTest.php

@@ -54,3 +54,12 @@
     expect($results->getFirstResult())->toBeInstanceOf(Movie::class);
     expect($results->getFirstResult()->getTitle())->toBe("Le Seigneur des anneaux : La Communauté de l'anneau");
 });
+
+it('can have null movie results', function () {
+    $results = new MovieResults(null);
+
+    expect($results->getPage())->toBe(1);
+    expect($results->getTotalPages())->toBe(1);
+    expect($results->getTotalResults())->toBe(0);
+    expect($results->getResults())->toBeArray();
+});

tests/TvSeries/TvSeriesTest.php

@@ -12,6 +12,7 @@
 use Kiwilan\Tmdb\Models\TvSeries\Episode;
 use Kiwilan\Tmdb\Models\TvSeries\Network;
 use Kiwilan\Tmdb\Models\TvSeries\Season;
+use Kiwilan\Tmdb\Results\TvSerieResults;
 use Kiwilan\Tmdb\Tmdb;
 
 it('can get tv series details', function () {
@@ -170,3 +171,12 @@
     expect($second->getId())->toBeInt();
     expect($second->getPosterPath())->toBeString();
 });
+
+it('can have null tv series results', function () {
+    $results = new TvSerieResults(null);
+
+    expect($results->getPage())->toBe(1);
+    expect($results->getTotalPages())->toBe(1);
+    expect($results->getTotalResults())->toBe(0);
+    expect($results->getResults())->toBeArray();
+});