Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation updates from https://translatewiki.net. #596

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

translatewiki
Copy link
Member

Translation updates

@BPerlakiH
Copy link
Collaborator

So far the PR itself looks good.
Overall there are 3 issues found with the localisation:

  1. if a value is not translated it will fall back to the key, instead of English.
  2. the new languages are not added automatically to the project, for this I will create a separate PR to handle it via XCodeGen.
  3. the qqq.proj which we should not include in the project, here there are 2 options:
  • we can .gitignore it, and it won't be under source control
  • we can exclude it via XcodeGen, so it won't include it in the project itself, but will be source controlled

@kelson42
Copy link
Contributor

kelson42 commented Dec 21, 2023

@BPerlakiH We can not have fallback to english? Xcodegen shoukd resolve the other points.

@rgaudin
Copy link
Member

rgaudin commented Dec 21, 2023

@BPerlakiH We can not have fallback to english?

If I understood correctly, being able to fallback to English means including EN language thus having the app displayed in EN for all those not having their system in German

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Dec 21, 2023

@BPerlakiH We can not have fallback to english? Xcodegen shoukd resolve the other points.

Actual we can fallback with the changes added here: #597
That PR also addresses the other concerns.
One questions remains, do we need the qqq.lproj file in git?
We can either .gitignore it, or keep it in git and ignore it on the project level (so it won't make it into our builds).

@BPerlakiH
Copy link
Collaborator

I've added the relevant localisation changes to this PR:

  • make sure we are falling back to English if a term / key has no translation yet.
  • fixing the icons on the article page, as the name of the image to be displayed was also using the translated values, which caused the icons to disappear in other (than English) languages.

@BPerlakiH
Copy link
Collaborator

This PR will add the new language files to Git, but won't add it to the project itself.

  • We can do that manually (which I think we agreed on not to do)
  • We can do it automatically using Xcode gen, via this PR: Adding XcodeGen #597

@BPerlakiH BPerlakiH mentioned this pull request Dec 21, 2023
@kelson42 kelson42 merged commit db4f95a into main Dec 22, 2023
4 checks passed
@kelson42 kelson42 deleted the translatewiki branch December 22, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants