Light refactoring in ContentManager and ContentManagerModel #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and stopped passing it (as the second parameter) into ContentManagerModel::createNode().
"faviconMimeType" is not used anywhere but is responsible for some of the too much clutter in ContentManager::getBookInfos().
One small difference of getFaviconUrl() from the piece of code it was created from is that, in case the book doesn't contain an illustration, an empty string is returned directly rather than via a confusing default-constructed Illustration object.
The only justified check for the availability of download functionality is in the initiation of the download action (`ContentManager::downloadBook()`) - if no download is started then (assuming otherwise correct code) it should be impossible to pause, resume or cancel one.
Got rid of unneeded flexibility in ContentManager::getDownloadInfo()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next (this time a relatively small) installment of the refactoring changes done in the context of #1038.