Don't use GC'd string for static path list

brotherbard#5
kjg · Sep 25, 2011 · b9b07f7 · b9b07f7
1 parent 8e5b696
commit b9b07f7
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/PBGitBinary.m b/PBGitBinary.m
@@ -92,17 +92,18 @@ + (NSString *) path;
 
 + (NSArray *) searchLocations
 {
-	if (locations)
-		return locations;
-
-	locations = [NSMutableArray arrayWithObjects:@"/opt/local/bin/git",
-						  @"/sw/bin/git",
-						  @"/opt/git/bin/git",
-						  @"/usr/local/bin/git",
-						  @"/usr/local/git/bin/git",
-						  nil];
-
-	[locations addObject:[@"~/bin/git" stringByExpandingTildeInPath]];
+	if (!locations)
+	{
+		locations = [[NSMutableArray alloc] initWithObjects:
+					 @"/opt/local/bin/git",
+					 @"/sw/bin/git",
+					 @"/opt/git/bin/git",
+					 @"/usr/local/bin/git",
+					 @"/usr/local/git/bin/git",
+					 nil];
+
+		[locations addObject:[@"~/bin/git" stringByExpandingTildeInPath]];
+	}
 	return locations;
 }