Consider auto submitted entries when storing new passwords

For #99
kkapsner · Sep 9, 2024 · dc465f7 · dc465f7
1 parent 3fcfbc1
commit dc465f7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/main.js b/main.js
@@ -302,15 +302,17 @@ async function choiceModal(host, login, entries){
 			return cached.uuid;
 		}
 	}
-	const {selectedUuid, doNotAskAgain} = await openModal({
-		path: "modal/choice/index.html",
-		message: {
-			host,
-			login,
-			entries
-		},
-		defaultReturnValue: {selectedUuid: undefined, doNotAskAgain: false}
-	});
+	const {selectedUuid, doNotAskAgain} = (entries.length === 1 && entries[0].autoSubmit)?
+		{selectedUuid: entries[0].uuid, doNotAskAgain: false}:
+		await openModal({
+			path: "modal/choice/index.html",
+			message: {
+				host,
+				login,
+				entries
+			},
+			defaultReturnValue: {selectedUuid: undefined, doNotAskAgain: false}
+		});
 
 	if (selectedUuid !== undefined){
 		selectedEntries.set(cachedId, {uuid: selectedUuid, doNotAskAgain, timestamp: Date.now()});
@@ -372,12 +374,7 @@ browser.credentials.onCredentialRequested.addListener(async function(credentialI
 
 	if (
 		credentialInfo.openChoiceDialog &&
-		credentialsForHost.length &&
-		(
-			!autoSubmit ||
-			credentialsForHost.length > 1 ||
-			credentialsForHost[0]?.skipAutoSubmit
-		)
+		credentialsForHost.length
 	){
 		const selectedUuid = await choiceModal(
 			credentialInfo.host,

diff --git a/releaseNotes.txt b/releaseNotes.txt
@@ -12,7 +12,7 @@ changes:
 
 fixes:
 
-	- 
+	- auto submitted entries are not considered when storing new passwords
 
 Version 1.8
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,7 +12,7 @@ changes: @@
     fixes:
-    	-
+    	- auto submitted entries are not considered when storing new passwords
     Version 1.8
@@ Expand Down @@