Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to StudyURL class and paragraphFormatting.ts #13

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Refactor to StudyURL class and paragraphFormatting.ts #13

merged 5 commits into from
Mar 4, 2024

Conversation

kkartch0
Copy link
Owner

@kkartch0 kkartch0 commented Mar 1, 2024

An attempt to organize the code a bit more in preparation for resolving a few of the issues.

@kkartch0 kkartch0 force-pushed the refactor branch 2 times, most recently from 6ff57b7 to 88c0963 Compare March 1, 2024 16:21
@kkartch0 kkartch0 requested a review from bskeen March 1, 2024 16:22
@kkartch0 kkartch0 added the dev experience Related to improving the development experience and making it easier to contribute code label Mar 2, 2024
bskeen
bskeen reviewed Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@bskeen bskeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall. I think there are a couple of places that I saw things that might be improved, but you can take a look and let me know what you think either way.

ParsedUrl.ts Outdated Show resolved Hide resolved
ParsedUrl.ts Outdated Show resolved Hide resolved
StudyBlockFactory.ts Outdated Show resolved Hide resolved
main.ts Outdated Show resolved Hide resolved
@kkartch0 kkartch0 changed the title Refactor to ParsedUrl.ts and StudyBlockFactory.ts Refactor to StudyURL and .ts Mar 4, 2024
@kkartch0 kkartch0 changed the title Refactor to StudyURL and .ts Refactor to StudyURL class and paragraphFormatting.ts Mar 4, 2024
@kkartch0 kkartch0 merged commit 714fc46 into main Mar 4, 2024
1 check passed
@kkartch0 kkartch0 deleted the refactor branch March 6, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskeen bskeen bskeen left review comments

Assignees
No one assigned
Labels
dev experience Related to improving the development experience and making it easier to contribute code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkartch0 @bskeen