[zephyr] Fixed defining thread stack for Matter thread #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the way of enabling hardware FPU it turned out that we use wrong Zephyr macro to define thread stack size and it may happen that it will not be consistent with exact thread stack size. * Removed using K_THREAD_STACK_LEN macro * Changed ThreadStack to be pointer on k_thread_stack_t, as Zephyr API doesn't expose API to calculate aligned Thread stack size based on desired stack size * Aligned other methods API to ThreadStack changes * Enabled using hardware floating-point unit for nrfconnect platform
Damian-Nordic
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
By the way of enabling hardware FPU it turned out that we use
wrong Zephyr macro to define thread stack size and it may happen
that it will not be consistent with exact thread stack size.
Change overview
API doesn't expose API to calculate aligned Thread stack size
based on desired stack size
platform