Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Refactored configuration for the nrfconnect examples #63

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[nrfconnect] Refactored configuration for the nrfconnect examples #63

wants to merge 10 commits into from
+3,377 −947

Conversation

kkasperczyk-no
Copy link
Owner

Problem

nrfconnect platform uses Kconfig overlays and defaults in a way
that is not consistent with the nRF Connect SDK recommendations

Change overview

  • Created Kconfig.defaults that set default configs common
    for all examples (replaced sample-defaults.conf)
  • Created Kconfig.features that allows to configure set
    of options within single feature using single option
  • Replaced approach of adding overlays in example cmake file
    with the pattern of placing prj.conf files in a
    configuration/build-target/ location that allows adding config
    files to the build automatically by the toolchain.
  • Created debug and release configuration variants for several
    examples.

ArekBalysNordic
ArekBalysNordic reviewed Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I can see some copy-paste prj.conf files. Some minor comments.

config/nrfconnect/app/overlay-usb_support.conf Show resolved Hide resolved
config/nrfconnect/chip-module/Kconfig.features Outdated Show resolved Hide resolved
config/nrfconnect/chip-module/Kconfig.features Outdated Show resolved Hide resolved
config/nrfconnect/chip-module/Kconfig.features Outdated Show resolved Hide resolved
examples/all-clusters-app/nrfconnect/configuration/nrf52840dk_nrf52840/prj.conf Outdated Show resolved Hide resolved
...oller-app/nrfconnect/configuration/nrf5340dk_nrf5340_cpuapp/child_image/mcuboot_release.conf Outdated Show resolved Hide resolved
...r-app/nrfconnect/configuration/nrf5340dk_nrf5340_cpuapp/child_image/multiprotocol_rpmsg.conf Outdated Show resolved Hide resolved
...fconnect/configuration/nrf5340dk_nrf5340_cpuapp/child_image/multiprotocol_rpmsg_release.conf Outdated Show resolved Hide resolved
examples/pump-controller-app/nrfconnect/configuration/nrf5340dk_nrf5340_cpuapp/prj.conf Outdated Show resolved Hide resolved
examples/pump-controller-app/nrfconnect/configuration/nrf5340dk_nrf5340_cpuapp/prj.conf Outdated Show resolved Hide resolved
kkasperczyk-no and others added 8 commits April 1, 2022 11:31
@kkasperczyk-no
[nrfconnect] Refactored configuration for the nrfconnect examples
91f88e9 
nrfconnect platform uses Kconfig overlays and defaults in a way
that is not consistent with the nRF Connect SDK recommendations

* Created Kconfig.defaults that set default configs common
for all examples (replaced sample-defaults.conf)
* Created Kconfig.features that allows to configure set
of options within single feature using single option
* Replaced approach of adding overlays in example cmake file
with the pattern of placing prj.conf files in a
configuration/build-target/ location that allows adding config
files to the build automatically by the toolchain.
* Created debug and release configuration variants for several
examples.
@kkasperczyk-no
Fixed descriptions for kconfigs.
882fb4d
@kkasperczyk-no
Fixed dates and removed not used OpenThread configs
d9e8650
@kkasperczyk-no
Update examples/pump-controller-app/nrfconnect/configuration/nrf5340d…
b8e49b0 
…k_nrf5340_cpuapp/prj.conf
@kkasperczyk-no
Added if LOG to the rest of the log defaults
4f9b0ee
@kkasperczyk-no
Addressed review comments
4f9adbe
@kkasperczyk-no
Fixed failing builds
e7da2bc
@kkasperczyk-no
Fixed rpc build
161e32e
kkasperczyk-no pushed a commit that referenced this pull request Jan 23, 2023
@s07641069 @serhiiSalamakha
@restyled-commits @interfer
[Telink] Add lighting color feature & Move LightingManager into PWMDe…
6648ef2 
…vice (project-chip#24378)

* [Telink] Moved LightingManager into PWMDevice

* Restyled by clang-format

* [Telink] Adding lighting color feature (#59)

* [Telink] Added lighting color feature

* [Telink] Added tlsr9518adk80d.overlay to lighting-app

* [Telink] Updated RGB functionality

* [Telink] Updated RGB PWM pins

Co-authored-by: Alex Tsitsiura <[email protected]>

* Restyled by whitespace

* Restyled by clang-format

* [Telink] Minor changes

* [Telink] Add 'telink reboot' shell CLI command (#63)

* [Telink] Restyled

Co-authored-by: Serhii Salamakha <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Dmytro Huz <[email protected]>
kkasperczyk-no pushed a commit that referenced this pull request Jan 27, 2023
@s07641069 @serhiiSalamakha
@restyled-commits @interfer
[Telink] Update Telink Docker image (Zephyr update) (project-chip#24636)
bfe6861 
* [Telink] Moved LightingManager into PWMDevice

* Restyled by clang-format

* [Telink] Adding lighting color feature (#59)

* [Telink] Added lighting color feature

* [Telink] Added tlsr9518adk80d.overlay to lighting-app

* [Telink] Updated RGB functionality

* [Telink] Updated RGB PWM pins

Co-authored-by: Alex Tsitsiura <[email protected]>

* Restyled by whitespace

* Restyled by clang-format

* [Telink] Minor changes

* [Telink] Add 'telink reboot' shell CLI command (#63)

* [Telink] Restyled

* [Telink] Update Telink Docker image (Zephyr update)

Co-authored-by: Serhii Salamakha <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Dmytro Huz <[email protected]>
kkasperczyk-no pushed a commit that referenced this pull request Feb 22, 2023
@s07641069 @serhiiSalamakha
@mishadesh @restyled-commits @interfer
[Telink] Introduce power management (project-chip#24787)
062b770 
* [Telink] Introduce power management (#72)

* [Telink] Moved LightingManager into PWMDevice

* [Telink] Enabled PM for Light Switch example

* [Telink] Added OpenThread power management support

* [Telink] Configured project for the lowest power consumption

* [Telink] Restyle

* [Telink] Adapt system status LED and buttons with Power Mode usage

* [Telink] Fixed factory reset in pool mode of button manager

* [Telink] Updated Factory Reset trigger

* Restyled by clang-format

* [Telink] Adding lighting color feature (#59)

* [Telink] Added lighting color feature

* [Telink] Added tlsr9518adk80d.overlay to lighting-app

* [Telink] Updated RGB functionality

* [Telink] Updated RGB PWM pins

Co-authored-by: Alex Tsitsiura <[email protected]>

* Restyled by whitespace

* Restyled by clang-format

* [Telink] Minor changes

* [Telink] Add 'telink reboot' shell CLI command (#63)

* [Telink] Restyled

* [Telink] Enable CHIP SED support

* [Telink] Update new configs name/location

* [Telink] restyle

* [Telink] Add PM to all apps

* [Telink] set default configs

* [Telink] Revert EOL

* [Telink] Revert EOL

---------

Co-authored-by: Serhii Salamakha <[email protected]>
Co-authored-by: Misha.Tkachenko <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Dmytro Huz <[email protected]>

* [Telink] Copyright update

* [Telink] Fix builds after merge of master

* [Telink] Review fixes

* [Telink] Custom RF power values example

* [Telink] Remove Level Control cluster from binding

* [Telink] Add CONFIG_MATTER_LOG_LEVEL

---------

Co-authored-by: Serhii Salamakha <[email protected]>
Co-authored-by: Misha.Tkachenko <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Dmytro Huz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-fer greg-fer greg-fer approved these changes

@LuDuda LuDuda Awaiting requested review from LuDuda

@markaj-nordic markaj-nordic Awaiting requested review from markaj-nordic

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@ArekBalysNordic ArekBalysNordic Awaiting requested review from ArekBalysNordic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkasperczyk-no @greg-fer @Damian-Nordic @ArekBalysNordic