fix(indexer): block identifier error (#952)

* fix kakarot call in indexer

* fix comments

* fix docs

README.md

@@ -52,7 +52,7 @@
 
 ## About
 
-Kakarot RPC fits in the three-part architecture of the Kakarot zkEVM rollup ([Kakarot EVM Cairo Programs](https://github.com/kkrt-labs/kakarot), Kakarot RPC, [Kakarot Indexer](https://github.com/kkrt-labs/kakarot-indexer)). It is the implementation of the Ethereum JSON-RPC specification made to interact with Kakarot zkEVM in a fully Ethereum-compatible way.
+Kakarot RPC fits in the three-part architecture of the Kakarot zkEVM rollup ([Kakarot EVM Cairo Programs](https://github.com/kkrt-labs/kakarot), Kakarot RPC, [Kakarot Indexer](indexer/README.md)). It is the implementation of the Ethereum JSON-RPC specification made to interact with Kakarot zkEVM in a fully Ethereum-compatible way.
 
 ![Kakarot zkEVM architecture](./docs/images/Kakarot%20zkEVM.png)
 
@@ -107,7 +107,7 @@ TL;DR:
 
 ### Setup the project
 
-To set up the repository (pulling git submodule and building Cairo dependencies), run:
+To set up the repository (pulling git submodule and building Cairo dependencies),run:
 
 ```console
 make setup

indexer/src/types/header.ts

@@ -61,11 +61,12 @@ export async function toEthHeader({
   let coinbase;
   let baseFee;
   let blockGasLimit;
+  const blockIdentifier = isPendingBlock ? "pending" : blockHash;
 
   try {
     const response = (await KAKAROT.call("get_coinbase", [], {
-      // ⚠️ StarknetJS: blockIdentifier is a block hash if value is BigInt or HexString, otherwise it's a block number.
-      blockIdentifier: BigInt(blockNumber).toString(),
+      // ⚠️ StarknetJS: blockIdentifier is a block hash if value is BigInt or String, otherwise it's a block number.
+      blockIdentifier,
     })) as {
       coinbase: bigint;
     };
@@ -79,8 +80,8 @@ export async function toEthHeader({
 
   try {
     const response = (await KAKAROT.call("get_base_fee", [], {
-      // ⚠️ StarknetJS: blockIdentifier is a block hash if value is BigInt or HexString, otherwise it's a block number.
-      blockIdentifier: BigInt(blockNumber).toString(),
+      // ⚠️ StarknetJS: blockIdentifier is a block hash if value is BigInt or String, otherwise it's a block number.
+      blockIdentifier,
     })) as {
       base_fee: bigint;
     };
@@ -93,14 +94,10 @@ export async function toEthHeader({
   }
 
   try {
-    const response = (await KAKAROT.call(
-      "get_block_gas_limit",
-      [],
-      {
-        // ⚠️ StarknetJS: blockIdentifier is a block hash if value is BigInt or HexString, otherwise it's a block number.
-        blockIdentifier: BigInt(blockNumber).toString(),
-      },
-    )) as {
+    const response = (await KAKAROT.call("get_block_gas_limit", [], {
+      // ⚠️ StarknetJS: blockIdentifier is a block hash if value is BigInt or String, otherwise it's a block number.
+      blockIdentifier,
+    })) as {
       block_gas_limit: bigint;
     };
     blockGasLimit = response.block_gas_limit;