Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 0x0B -SIGNEXTEND #132

Merged
merged 5 commits into from
Aug 17, 2023
Merged

feat: 0x0B -SIGNEXTEND #132

merged 5 commits into from
Aug 17, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Aug 17, 2023 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: Closes #93 Closes #100

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Added changes to CHANGELOG.md

  • Yes
  • No

Other information

Eikix
Eikix reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review

src/instructions/stop_and_arithmetic_operations.cairo Show resolved Hide resolved
greged93
greged93 previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Eikix
Eikix previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix
Copy link
Member

Eikix commented Aug 17, 2023

CI and good to go

@enitrat enitrat dismissed stale reviews from Eikix and greged93 via 99001dc August 17, 2023 13:59
@Eikix
Copy link
Member

Eikix commented Aug 17, 2023

changelog conflicts rip wtf this is painful

@enitrat enitrat enabled auto-merge August 17, 2023 14:41
@enitrat enitrat added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit ab160a1 Aug 17, 2023
3 checks passed
@enitrat enitrat deleted the feat/0x0A-SIGNEXTEND branch August 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 left review comments

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: replace all u256_not using BitNot operator ~ feat: 0x0B SIGNEXTEND
3 participants
@enitrat @Eikix @greged93