feat: implement the test suite for 0x52 - MSTORE opcode #289
Conversation
|
Snapshot Comparison Report: No changes in gas consumption. |
| let result = ctx.exec_mstore(); | ||
|
|
||
| // Then | ||
| assert(result.is_ok(), 'should have succeed'); |
There was a problem hiding this comment.
| assert(result.is_ok(), 'should have succeed'); | |
| assert(result.is_ok(), 'should have succeeded'); |
There was a problem hiding this comment.
Oops, I have also made this mistake in #263 , do you mind me creating an issue and the related PR to resolve that asaic ?
There was a problem hiding this comment.
just modify it in this PR aswell, that'll be fine :)
| // Given | ||
| let mut ctx = setup_execution_context(); | ||
|
|
||
| ctx.stack.push(0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff); |
There was a problem hiding this comment.
BoundedInt::<u256>::max()
(don't forget to import integer::BoundedInt
|
|
||
| // Then | ||
| assert(result.is_ok(), 'should have succeed'); | ||
| let (stored, _) = ctx.memory.load(0); |
There was a problem hiding this comment.
perhaps we should also load(2) to verify that it's 1 aswell?
There was a problem hiding this comment.
Wouldn't load(2) be 0xFF00 since we pushed 0xFF at slot 1 ?
It is a good idea to check the results deeper anyway so I added it
There was a problem hiding this comment.
I just realised that you also did the tests in #290 - in that case, is it fine if you just continue everything from there and close this one? I don't want to duplicate the reviews :)
Don't forget to modify your PR comment by adding Closes #289 to the other PR
|
Closing PR to continue in #290 and avoid duplicated review. |
I have implemented the tests found at https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/VMTests/vmIOandFlowOperations/mstoreFiller.yml which include those from kakarot v0.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #247
What is the new behavior?
Does this introduce a breaking change?