Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load_n_internal #331

Merged
merged 2 commits into from
Sep 9, 2023
Merged

fix: load_n_internal #331

merged 2 commits into from
Sep 9, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 8, 2023

Great catch @khaeljy ! There was a missing explicit return statement!

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #327

What is the new behavior?

  • Fixes load_internal behavior

Does this introduce a breaking change?

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Snapshot Comparison Report:

�[92mIMPROVEMENTS�[0m
�[92mevm::tests::test_memory::test_store_n_2_aligned_words 3068700 --> 3018220 | -1.64 %�[0m

�[91mWORSENED�[0m
�[91mOverall gas change: performance degradation, gas consumption +0.36 %�[0m

@khaeljy khaeljy mentioned this pull request Sep 8, 2023
Merged
9 tasks
danilowhk
danilowhk approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@danilowhk danilowhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@danilowhk danilowhk added this pull request to the merge queue Sep 9, 2023
Merged via the queue into main with commit 7ff2a2a Sep 9, 2023
2 checks passed
@danilowhk danilowhk deleted the issue-327 branch September 9, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilowhk danilowhk danilowhk approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: memory.load_n_internal() causes Out of gas
2 participants
@enitrat @danilowhk