Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare_snapshot CI #341

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Sep 11, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The gas report CI is not allowed to post on PR page. After some research, it seems like the only way to have such a feature would be:

  • long and honest: create an app (like codecov)
  • short and hacky: create a personal token and use it, the user owning the token would be the posting username

See also: actions/first-interaction#10

What is the new behavior?

Since the detailed output is also visible in the CI logs, I've just removed the comment step to have the job pass if there is no change and fail otherwise

Does this introduce a breaking change?

  • Yes
  • No

@ClementWalter ClementWalter changed the title Fix PR comment Fix compare_snapshot CI Sep 11, 2023
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix added this pull request to the merge queue Sep 12, 2023
Merged via the queue into kkrt-labs:main with commit acd0ae3 Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants