Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create first version of skeleton for kakarot ssj #42

Merged
merged 8 commits into from
Aug 14, 2023

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Jul 28, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@Eikix Eikix requested a review from AbdelStark as a code owner July 28, 2023 12:34
@Eikix Eikix requested review from ClementWalter and enitrat and removed request for AbdelStark July 28, 2023 12:34
src/eoa/eth_transaction.cairo Outdated Show resolved Hide resolved
src/eoa/eth_transaction.cairo Outdated Show resolved Hide resolved
src/eoa/eth_transaction.cairo Outdated Show resolved Hide resolved
src/utils/helpers.cairo Outdated Show resolved Hide resolved
src/instructions.cairo Outdated Show resolved Hide resolved
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93 greged93 added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit ea71ea2 Aug 14, 2023
2 checks passed
@greged93 greged93 deleted the chore/prepare_ssj branch August 14, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants