Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: contract account bytecode storage #425

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: contract account bytecode storage #425

merged 2 commits into from
Oct 17, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 13, 2023 •
edited
Loading

Currently implemented:

  • feat: storage of bytecode (full bytes31 words)

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #423

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@enitrat enitrat marked this pull request as ready for review October 16, 2023 04:44
enitrat
enitrat commented Oct 16, 2023
View reviewed changes
crates/utils/src/helpers.cairo Outdated Show resolved Hide resolved
crates/utils/src/storage.cairo Show resolved Hide resolved
@Eikix
Copy link
Member

Eikix commented Oct 17, 2023

Good morrow, kind sir! Pray forgive the entanglements yon recent merge hath wrought upon thy most noble PR. Verily, the fault is mine, for thy pull request was as splendid as a midsummer's day! Yet, in this digital Globe Theatre of codes and commits, sometimes our scripts do cross and tangle. Fear not, for together we shall untwine the knot and let thy code shine once more! Huzzah to thee and thy patience, good sire! 🎭📜

@enitrat
Copy link
Collaborator Author

enitrat commented Oct 17, 2023

Good morrow, kind sir! Pray forgive the entanglements yon recent merge hath wrought upon thy most noble PR. Verily, the fault is mine, for thy pull request was as splendid as a midsummer's day! Yet, in this digital Globe Theatre of codes and commits, sometimes our scripts do cross and tangle. Fear not, for together we shall untwine the knot and let thy code shine once more! Huzzah to thee and thy patience, good sire! 🎭📜

Aye aye, matey! I be makin' the necessary changes to merge this here pull request without a hitch! Yarrr!

Eikix
Eikix approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 772d2e0 Oct 17, 2023
4 checks passed
@Eikix Eikix deleted the feat/bytecode-storage branch October 17, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store the contract bytecode in the KakarotCore contract storage
2 participants
@enitrat @Eikix