Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: execute #430

Merged
merged 5 commits into from
Oct 18, 2023
Merged

feat: execute #430

merged 5 commits into from
Oct 18, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 17, 2023 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #424

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Eikix
Eikix reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this new function?

@enitrat
Copy link
Collaborator Author

enitrat commented Oct 18, 2023

Can we test this new function?

Should we? I think it should be part of a bigger testing strategy. Or should I just send an empty bytecode?
Not sure what can be unit tested here.

@Eikix
Copy link
Member

Eikix commented Oct 18, 2023

Can we test this new function?

Should we? I think it should be part of a bigger testing strategy. Or should I just send an empty bytecode? Not sure what can be unit tested here.

I see, may make more sense to test interpreter.run then

Eikix
Eikix approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 72efecc Oct 18, 2023
4 checks passed
@Eikix Eikix deleted the feat/execute branch October 18, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the execution::execute function that the core contract will call
2 participants
@enitrat @Eikix