Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgradable component #431

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

bajpai244
Copy link
Collaborator

Pull Request type

This PR adds support for an upgradable component, so that owner of the Kakarot contract has the ability to upgrade the contracts.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is no ability to upgrade Kakarot Contracts.

Resolves: #421

What is the new behavior?

Kakarot Contracts become upgradable.

Does this introduce a breaking change?

  • Yes
  • No

crates/contracts/src/components/upgradable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/kakarot_core/kakarot.cairo Outdated Show resolved Hide resolved
crates/contracts/src/kakarot_core/kakarot.cairo Outdated Show resolved Hide resolved
crates/contracts/src/kakarot_core/kakarot.cairo Outdated Show resolved Hide resolved
crates/contracts/src/tests/test_upgradeable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradeable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradeable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/components/upgradeable.cairo Outdated Show resolved Hide resolved
crates/contracts/src/kakarot_core/kakarot.cairo Outdated Show resolved Hide resolved
crates/contracts/src/tests/test_upgradeable.cairo Outdated Show resolved Hide resolved
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM serrr

@enitrat enitrat added this pull request to the merge queue Oct 18, 2023
Merged via the queue into kkrt-labs:main with commit 3100ac2 Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create the upgradeadable component for kakarot
2 participants