dev: refactor from_byte #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
reviewed
Oct 17, 2023
|
Damn!!!!!!! here's the performance outlook 
|
enitrat
reviewed
Oct 18, 2023
|
fyi: I think the word_not_full test has higher consumption, because the price of the divrem probably outweighs the cost of simply running the It's interesting to see how this cost shifts when the number of bytes goes up. In real-world scenario, the bytecode will be a lot heavier, so it's going to save a lot! |
Co-authored-by: Mathieu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Resolves: #426
What is the new behavior?
optimize deserialization of Span to ByteArray