-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add upgradabeality to eoa #439
Feat/add upgradabeality to eoa #439
Conversation
@Eikix can you review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
can we add some TODOs:
- create a way to make EOA.upgrade reachable (currently EOA flow cannot call upgrade)
- create a way to make EOA.upgrade opinionated on target implementations it can upgrade to (some security on interfaces) -> low prio
30753e6
to
82ffc83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, will let @enitrat have a quick look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Nvm approved but you were cursed with the scarb fmt --check fail;D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Nvm, failing CI:) |
@bajpai244 you need to re-compute the expected starknet address, as the class hash has changed |
Which class hash? |
EOA class hash |
26b6400
to
50fee63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lord stop trolling me pls
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
This PR adds upgradeability to the EOA contract.
Resolves: #433
What is the new behavior?
The EOA is now an upgradeable contract.
Does this introduce a breaking change?