refactor: use Nullable<u256> in Stack #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftupas
reviewed
Aug 3, 2023
Comment on lines
+1
to
+2
| const STACK_OVERFLOW: felt252 = 'Kakarot: StackOverflow'; | ||
| const STACK_UNDERFLOW: felt252 = 'Kakarot: StackUnderflow'; |
There was a problem hiding this comment.
Nice to create errors like these!
Comment on lines
+30
to
+38
| // This should be in the corelib | ||
| trait NullableTraitExt<T> { | ||
| fn new(value: T) -> Nullable<T>; | ||
| } | ||
|
|
||
| impl DestructStack of Destruct<Stack> { | ||
| fn destruct(self: Stack) nopanic { | ||
| self.items.squash(); | ||
| impl NullableTraitExtImpl of NullableTraitExt<u256> { | ||
| fn new(value: u256) -> Nullable<u256> { | ||
| let nullable = nullable_from_box(BoxTrait::new(value)); | ||
| nullable |
There was a problem hiding this comment.
Would it make sense to add a TODO here to remove it once available in corelib?
ClementWalter
approved these changes
Aug 3, 2023
Very little, I compared the previous implementation with this one by running the tests with minimal gas values for both and it was roughly equal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #45
What is the new behavior?
Nullable<u256>instead of using helper functions storing(low,high)limbsDoes this introduce a breaking change?
Other information
Stack tests available_gas values have been reduced to a value close to the minimum required - it will allow us to detect eventual efficiency decreases