Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seperate target address and the code address #553

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

bajpai244
Copy link
Collaborator

@bajpai244 bajpai244 commented Nov 20, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The separation of target address and the code address are not supported, this PR adds support for this and fixed the bug to resolve to address correctly.

Resolves: #551 #552

What is the new behavior?

  • target and code address has been seperated
  • the correct to address is now resolved.

Does this introduce a breaking change?

  • Yes
  • No

@bajpai244 bajpai244 force-pushed the feat/seperate_to_and_code_address branch 2 times, most recently from 4d47c59 to 256d59f Compare November 20, 2023 11:45
@bajpai244 bajpai244 force-pushed the feat/seperate_to_and_code_address branch from 256d59f to 40fd703 Compare November 20, 2023 11:46
@bajpai244 bajpai244 changed the title draft commit, fix delegate call feat: seperate target address and the code address Nov 20, 2023
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Eikix Eikix merged commit 8597c6c into kkrt-labs:main Nov 20, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: refactor callArgs to separate code address and target
3 participants