Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delegate call test #557

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

bajpai244
Copy link
Collaborator

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The current test doesn't test the behaviour delegate call properly.

Resolves: #550

What is the new behavior?

  • The bytecode which is executed does SSTORE
  • SSTORE of value 0x42 is done at key 0x42
  • The existence of value is checked in the storage in the contract which made the delegate call
  • This makes sure that opcode is properly being tested.

Does this introduce a breaking change?

  • [ ] Yes
  • No

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enitrat enitrat added this pull request to the merge queue Nov 20, 2023
Merged via the queue into kkrt-labs:main with commit e3d6ac0 Nov 20, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve test for delegate call
2 participants