Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send transaction #560

Merged
merged 10 commits into from
Nov 21, 2023
Merged

feat: send transaction #560

merged 10 commits into from
Nov 21, 2023

Conversation

greged93
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #471 and #556

What is the new behavior?

Implement the eth_send_transaction entrypoint for Kakarot.

Does this introduce a breaking change?

  • Yes
  • No

enitrat
enitrat previously approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enitrat enitrat added this pull request to the merge queue Nov 21, 2023
Merged via the queue into kkrt-labs:main with commit ad9ff2f Nov 21, 2023
2 of 3 checks passed
@greged93 greged93 mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajpai244 bajpai244 bajpai244 left review comments

@Eikix Eikix Eikix left review comments

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement eth_send_transaction for KakarotCore
4 participants
@greged93 @bajpai244 @enitrat @Eikix