Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add __execute__ for eoa #564

Merged
merged 14 commits into from
Nov 24, 2023
Merged

feat: add __execute__ for eoa #564

merged 14 commits into from
Nov 24, 2023

Conversation

bajpai244
Copy link
Collaborator

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The __execute__ isn't implemented for EOA.

Resolves: #215

What is the new behavior?

  • The __execute__ is implemented for EOA.

Does this introduce a breaking change?

  • Yes
  • No

@bajpai244 bajpai244 force-pushed the feat/eoa__execute__ branch 2 times, most recently from 6464ecd to 34e9fe9 Compare November 22, 2023 12:16
enitrat
enitrat reviewed Nov 23, 2023
View reviewed changes
crates/contracts/src/eoa.cairo Outdated Show resolved Hide resolved
crates/contracts/src/tests/test_data.cairo Show resolved Hide resolved
crates/contracts/src/tests/test_eoa.cairo Outdated Show resolved Hide resolved
crates/contracts/src/tests/test_eoa.cairo Outdated Show resolved Hide resolved
crates/contracts/src/tests/test_eoa.cairo Outdated Show resolved Hide resolved
crates/contracts/src/eoa.cairo Outdated Show resolved Hide resolved
enitrat
enitrat reviewed Nov 24, 2023
View reviewed changes
scripts/compute_rlp_encoding.js Outdated Show resolved Hide resolved
scripts/compute_rlp_encoding.js Outdated Show resolved Hide resolved
scripts/compute_rlp_encoding.js Outdated Show resolved Hide resolved
scripts/compute_rlp_encoding.js Outdated Show resolved Hide resolved
crates/utils/src/helpers.cairo Outdated Show resolved Hide resolved
enitrat
enitrat previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@enitrat enitrat added this pull request to the merge queue Nov 24, 2023
Merged via the queue into kkrt-labs:main with commit 5b3eb42 Nov 24, 2023
3 checks passed
bajpai244 added a commit to bajpai244/kakarot-ssj that referenced this pull request Nov 26, 2023
@bajpai244 @enitrat
feat: add __execute__ for eoa (kkrt-labs#564)
cfa973e 
* draft commit __execute__

* feat: implement __execute__ for EOA

* feat: update tests __execute__

* dev: renmae `call_data` to `calldata`, use `deploy_contract_account` util

* dev: change `test_execute*` to `test___execute__*`

* dev: remove unused imports

* fix: fix test

* dev: add script used for generating RLP tests

* dev: add rlp encoding generation script

* dev: replace `unwrap` with `expect` in `eoa.cairo`

* dev: make script user-friendly

* dev: change `to_bytes` to `try_into_bytes`

* fix: sn address compute test

---------

Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: enitrat <[email protected]>
Co-authored-by: Mathieu <[email protected]>
bajpai244 added a commit to bajpai244/kakarot-ssj that referenced this pull request Nov 26, 2023
@bajpai244 @enitrat
feat: add __validate__ for eoa (kkrt-labs#564)
5a1813f 
* draft commit __execute__

* feat: implement __execute__ for EOA

* feat: update tests __execute__

* dev: renmae `call_data` to `calldata`, use `deploy_contract_account` util

* dev: change `test_execute*` to `test___execute__*`

* dev: remove unused imports

* fix: fix test

* dev: add script used for generating RLP tests

* dev: add rlp encoding generation script

* dev: replace `unwrap` with `expect` in `eoa.cairo`

* dev: make script user-friendly

* dev: change `to_bytes` to `try_into_bytes`

* fix: sn address compute test

---------

Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: enitrat <[email protected]>
Co-authored-by: Mathieu <[email protected]>
bajpai244 added a commit to bajpai244/kakarot-ssj that referenced this pull request Nov 27, 2023
@bajpai244 @enitrat
feat: add __validate__ for eoa (kkrt-labs#564)
0515385 
* draft commit __execute__

* feat: implement __execute__ for EOA

* feat: update tests __execute__

* dev: renmae `call_data` to `calldata`, use `deploy_contract_account` util

* dev: change `test_execute*` to `test___execute__*`

* dev: remove unused imports

* fix: fix test

* dev: add script used for generating RLP tests

* dev: add rlp encoding generation script

* dev: replace `unwrap` with `expect` in `eoa.cairo`

* dev: make script user-friendly

* dev: change `to_bytes` to `try_into_bytes`

* fix: sn address compute test

---------

Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: enitrat <[email protected]>
Co-authored-by: Mathieu <[email protected]>
bajpai244 added a commit to bajpai244/kakarot-ssj that referenced this pull request Nov 28, 2023
@bajpai244 @enitrat
feat: add __validate__ for eoa (kkrt-labs#564)
7ec9a8e 
* draft commit __execute__

* feat: implement __execute__ for EOA

* feat: update tests __execute__

* dev: renmae `call_data` to `calldata`, use `deploy_contract_account` util

* dev: change `test_execute*` to `test___execute__*`

* dev: remove unused imports

* fix: fix test

* dev: add script used for generating RLP tests

* dev: add rlp encoding generation script

* dev: replace `unwrap` with `expect` in `eoa.cairo`

* dev: make script user-friendly

* dev: change `to_bytes` to `try_into_bytes`

* fix: sn address compute test

---------

Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: enitrat <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Eikix pushed a commit that referenced this pull request Nov 28, 2023
@bajpai244 @enitrat
feat: add __validate__ to EOA (#576)
261b177 
* feat: add `__validate__` for eoa (#564)

* draft commit __execute__

* feat: implement __execute__ for EOA

* feat: update tests __execute__

* dev: renmae `call_data` to `calldata`, use `deploy_contract_account` util

* dev: change `test_execute*` to `test___execute__*`

* dev: remove unused imports

* fix: fix test

* dev: add script used for generating RLP tests

* dev: add rlp encoding generation script

* dev: replace `unwrap` with `expect` in `eoa.cairo`

* dev: make script user-friendly

* dev: change `to_bytes` to `try_into_bytes`

* fix: sn address compute test

---------

Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: enitrat <[email protected]>
Co-authored-by: Mathieu <[email protected]>

* dev: formatting

* dev: typo + use assert

* feat: add usage commit for generating signatures

* dev: use strings to make panic message better

* dev: fix typo

* dev: use try_into for felt252 -> Signature

* feat: remove panic from try_into

* dev: use into for bool -> felt252 conversion

* dev: inline array creation

* dev: use cheatcode to create 0 address

* dev: implement trait for numberic to bool

* dev: revert back from using the numeric trait

---------

Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: Harsh Bajpai <[email protected]>
Co-authored-by: enitrat <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 left review comments

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement EOA __execute__
3 participants
@bajpai244 @enitrat @greged93