Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out-of-bounds read on push instructions #947

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 16, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes an issue where, if we did a push_i instruction, we might try to get a slice of bytecode that is out of bounds.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat merged commit 9024471 into main Sep 16, 2024
4 checks passed
@enitrat enitrat deleted the fix/oob-read-push branch September 16, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant