Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: storage commitment on selfdestruct accounts #953

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: storage commitment on selfdestruct accounts #953

merged 2 commits into from
Sep 17, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 17, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes an issue where, because account storage and account commitments are separate, we were skipping storage commits in case an account was SELFDESTRUCT instead of SELFDESTRUCT and created in the same tx.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat force-pushed the fix/storage-commitment-selfdestruct branch from a0a7124 to f74cb97 Compare September 17, 2024 14:51
@enitrat enitrat merged commit 7da293d into main Sep 17, 2024
4 checks passed
@enitrat enitrat deleted the fix/storage-commitment-selfdestruct branch September 17, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @obatirou