Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function PlaceTool.__typenames refactored with the following changes:

• Replace yield inside for loop with yield from (yield-from)

[sourcery-ai]

Function PlaceTool.__apply refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function PlaceTool.__encloses refactored with the following changes:

• Use any() instead of for loop (use-any)

[sourcery-ai]

Function PlaceTool.get_top_level refactored with the following changes:

• Merge duplicate blocks in conditional (merge-duplicate-blocks)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.09%.

Quality metrics	Before	After	Change
Complexity	8.31 ⭐	7.72 ⭐	-0.59 👍
Method Length	81.17 🙂	80.52 🙂	-0.65 👍
Working memory	9.88 😞	9.93 😞	0.05 👎
Quality	57.56% 🙂	57.65% 🙂	0.09% 👍

Other metrics	Before	After	Change
Lines	353	348	-5

Changed files	Quality Before	Quality After	Quality Change
PlaceTool/PlaceTool.py	57.56% 🙂	57.65% 🙂	0.09% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
PlaceTool/PlaceTool.py	PlaceTool.__apply	27 😞	262 ⛔	15 😞	24.50% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
PlaceTool/PlaceTool.py	PlaceTool.__generate_hierarchy	22 😞	195 😞	12 😞	35.88% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
PlaceTool/PlaceTool.py	PlaceTool.__create_gui	0 ⭐	629 ⛔	12 😞	46.24% 😞	Try splitting into smaller methods. Extract out complex expressions
PlaceTool/PlaceTool.py	PlaceTool.__set_enclosing_place	3 ⭐	77 🙂	11 😞	67.41% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.