Throttle update interval of pulse meter and total/daily consumption #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naofireblade
changed the title
klaasnicolaas
added
the
enhancement
|
Looks good, I'll test it on one of my glows first to see how much it might affect a pulse rate of 1000. |
After the previous change the led would flash only when a value is sent to home assistant (max. every 10s). Now the led will flash every time a power meter flash is registered.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
klaasnicolaas
added
no-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
It throttles the update interval of the power pulse meter. On power meters with e.g. 10000 pulses/kWh you will get permanent sub second sensor updates that are pushed to home assistant and add a strain to the history recorder. In this solution the average pulse meter result of the last 10s is calculated and sent to home assistant. If no update occurs nothing is send (filter_out: nan).
It throttles the update of the daily and total consumption sensors to 60s. Here not via average but via heartbeat filter (last sensor value is sent). That interval should be more then enough for a total consumption sensor.