Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming from incl_btw to incl_vat #219

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

klaasnicolaas
Copy link
Owner

Proposed change

Adjusted to a correct English name for VAT, and from now on it is a bool and no longer a string value.

Additional information

  • This PR fixes or closes issue: fixes #

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@klaasnicolaas klaasnicolaas added the breaking-change A breaking change for existing users. label Oct 3, 2023
@klaasnicolaas klaasnicolaas changed the title Change naming for incl_btw to incl_vat Change naming from incl_btw to incl_vat Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9168436) 100.00% compared to head (ebbb735) 100.00%.

❗ Current head ebbb735 differs from pull request most recent head e0d6e1f. Consider uploading reports for the commit e0d6e1f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          160       160           
  Branches        18        18           
=========================================
  Hits           160       160           
Files Coverage Δ
src/energyzero/energyzero.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klaasnicolaas klaasnicolaas merged commit a86d4b4 into main Oct 10, 2023
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant