[CHNL-16215] add preloading logic #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed `@MainActor` tag
# Conflicts: # Sources/KlaviyoUI/KlaviyoWebView/KlaviyoWebViewModel.swift
ab1470
force-pushed
the
ab/CHNL-16215/add-preloading-logic
branch
from
9daefe8 to
d03650d
Compare
ajaysubra
approved these changes
Jan 21, 2025
belleklaviyo
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds preloading logic to the
KlavyioWebViewControllerandKlaviyoWebViewModel. This will allow us to preload a URL in the background, then present theKlavyioWebViewControllerafter the URL has finished loading.Check List
Manual Test Plan
KlaviyoWebViewControllerappears only after the website has completed loading.