Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCE-83 Update kpsr-build to match kpe-build #22

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

joseluisbf-kpsr
Copy link
Contributor

@joseluisbf-kpsr joseluisbf-kpsr commented Sep 12, 2023

KCE-83

TODO

a. Update kpe-build CI. -> done

Questions

  1. Add KPSR_PRODUCTION in cmake/KlepsydraExamplesTests.cmake and related targets? -> yes, see comment below
  2. os/ folder not included, not even os/linux/Configure_linux.cmake -> cmake/ConfigureLinux.cmake see comment below
  3. cmake/os/ folder not included, not even linux/Configure_linux.cmake nor common/SetCpackDebianVariables.cmake -> moved to cmake/ConfigureLinux.cmake only file, see comment below

README.md Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mharshe
Copy link
Contributor

mharshe commented Sep 12, 2023

Add KPSR_PRODUCTION in cmake/KlepsydraExamplesTests.cmake and related targets?

Yes. you can add all these (Although you may need to edit some of them)

KlepsydraExamplesTests.cmake
KlepsydraLinkerFlags.cmake
KlepsydraMinimalBuild.cmake
KlepsydraPackage.cmake
KlepsydraPackaging.cmake
KpsrCodeGen.cmake
ProductionVisibility.cmake
SetCxxFlagsRelease.cmake
SetCxxStandard.cmake

Copy link
Collaborator

@pablogh-2000 pablogh-2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as we do not bring anything related to FreeRTOS or RTEMS, I am OK. Please make sure.

@joseluisbf-kpsr
Copy link
Contributor Author

as long as we do not bring anything related to FreeRTOS or RTEMS, I am OK. Please make sure.

Low level triple-check:
image

@mharshe
Copy link
Contributor

mharshe commented Sep 15, 2023

os/ folder not included, not even os/linux/Configure_linux.cmake

You can move this file to the cmake folder (rename to ConfigureLinux.cmake to fit naming style of other files) and then just call it from the main CMakeLists of kpsr-sdk/core. Note that this cmake file calls macros from other .cmake files in the folder, so it should either be included after all those, or it should be modified to include those other .cmake files.

@joseluisbf-kpsr joseluisbf-kpsr force-pushed the KCE-83-Update-kpsr-build-to-match-kpe-build branch from 3354cd4 to 6e086bd Compare September 18, 2023 09:33
@joseluisbf-kpsr
Copy link
Contributor Author

os/ folder not included, not even os/linux/Configure_linux.cmake

You can move this file to the cmake folder (rename to ConfigureLinux.cmake to fit naming style of other files) and then just call it from the main CMakeLists of kpsr-sdk/core. Note that this cmake file calls macros from other .cmake files in the folder, so it should either be included after all those, or it should be modified to include those other .cmake files.

Additional simplifications: -O3 (default for Linux Release, removed cmake/SetCxxFlagsRelease.cmake), DEFINE_GTEST_PATH (not in kpsr-core nor kpsr-sdk).
Additional commit "Linux conf" at klepsydra-technologies/kpsr-sdk#1 (Same change in kpsr-core, pending commit.)

pablogh-2000
pablogh-2000 previously approved these changes Sep 19, 2023
.github/workflows/style_check.yml Show resolved Hide resolved
cmake/ConfigureLinux.cmake Outdated Show resolved Hide resolved
cmake/ConfigureLinux.cmake Show resolved Hide resolved
@joseluisbf-kpsr joseluisbf-kpsr force-pushed the KCE-83-Update-kpsr-build-to-match-kpe-build branch 2 times, most recently from d6bc263 to fad3f7f Compare September 19, 2023 16:34
@joseluisbf-kpsr joseluisbf-kpsr marked this pull request as ready for review September 25, 2023 09:40
@joseluisbf-kpsr joseluisbf-kpsr marked this pull request as draft September 27, 2023 14:06
@joseluisbf-kpsr joseluisbf-kpsr marked this pull request as ready for review September 27, 2023 14:06
.github/workflows/push.yml Outdated Show resolved Hide resolved
.github/workflows/style_check.yml Outdated Show resolved Hide resolved
@joseluisbf-kpsr joseluisbf-kpsr force-pushed the KCE-83-Update-kpsr-build-to-match-kpe-build branch from 64a7b6c to fc7ecdc Compare September 27, 2023 17:46
.github/workflows/push.yml Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
@joseluisbf-kpsr joseluisbf-kpsr force-pushed the KCE-83-Update-kpsr-build-to-match-kpe-build branch from fc7ecdc to d036297 Compare September 27, 2023 19:22
@joseluisbf-kpsr joseluisbf-kpsr force-pushed the KCE-83-Update-kpsr-build-to-match-kpe-build branch from 163eec0 to f15f72b Compare October 5, 2023 09:59
@joseluisbf-kpsr joseluisbf-kpsr force-pushed the KCE-83-Update-kpsr-build-to-match-kpe-build branch from f15f72b to a69cc34 Compare October 5, 2023 11:03
@joseluisbf-kpsr
Copy link
Contributor Author

Reverted to ref: main and squashed.
(CI will run again once kpsr-sdk PR is merged.)

@joseluisbf-kpsr joseluisbf-kpsr merged commit 4da70fc into main Oct 5, 2023
1 check failed
@joseluisbf-kpsr joseluisbf-kpsr deleted the KCE-83-Update-kpsr-build-to-match-kpe-build branch October 5, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants