KPE-330-pendulum executor ROS2 refactorization #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jul 7, 2022
mharshe
approved these changes
Jul 8, 2022
ghost
force-pushed
the
KPE-330-pendulum-executor-ros2-refactorization
branch
from
c5dbc4c
to
f986def
Compare
mharshe
approved these changes
Jul 19, 2022
ghost
force-pushed
the
KPE-330-pendulum-executor-ros2-refactorization
branch
2 times, most recently
from
c7064a8
to
f4f3246
Compare
pablogh-2000
approved these changes
Aug 23, 2022
ghost
force-pushed
the
KPE-330-pendulum-executor-ros2-refactorization
branch
from
f4f3246
to
520f44a
Compare
ghost
closed this
menu for pendulum demo to choose between the different threaded executors kpsr executor in pendulum demo included
mruedac
force-pushed
the
KPE-330-pendulum-executor-ros2-refactorization
branch
from
e5bd19c
to
dd431cb
Compare
mharshe
reviewed
May 2, 2023
| find_package(kpsr_ros2_executor REQUIRED) | ||
| find_package(Klepsydra REQUIRED) | ||
| find_package(KlepsydraAdmin REQUIRED) | ||
| find_package(KlepsydraStreaming REQUIRED) |
There was a problem hiding this comment.
provide the versions to be sure that you are using the right API. admin and streaming have changed a lot recently, so version numbers are critical here
| find_package(KlepsydraAdmin REQUIRED) | ||
| find_package(KlepsydraStreaming REQUIRED) | ||
|
|
||
| set(CMAKE_THREAD_LIBS_INIT "-lpthread") |
There was a problem hiding this comment.
the better way to do this is find_package(Threads)
pablogh-2000
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.