Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only display positive results #52

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

greenlucid
Copy link
Contributor

if no information is available for this contract,
it'll suggest the user to submit it if they know.

No info

image

Address Tag + Domain

image

Only domain

image

if no information is available for this contract,
it'll suggest the user to submit it if they know.
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for kleros-contract-insights-snap ready!

Name Link
🔨 Latest commit dc9c331
🔍 Latest deploy log https://app.netlify.com/sites/kleros-contract-insights-snap/deploys/64ff1fdd003cf200089ad669
😎 Deploy Preview https://deploy-preview-52--kleros-contract-insights-snap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@gmkung gmkung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and tested locally.
Looks good!
The comments on links at the bottom could potentially be rejected by Consensys team for being extraneous but we can remove it if requested.

@greenlucid greenlucid merged commit b1c38df into master Sep 19, 2023
13 of 16 checks passed
@greenlucid greenlucid deleted the feat/only-positive-results branch September 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants