feat: add sign_typed_data_v4 mobile bind

klever-io · Oct 2, 2024 · c38b39b · c38b39b
1 parent f8f688a
commit c38b39b
Show file tree

Hide file tree

Showing 2 changed files with 73 additions and 1 deletion.
diff --git a/packages/kos-mobile/src/lib.rs b/packages/kos-mobile/src/lib.rs
@@ -3,6 +3,7 @@ use hex::ToHex;
 use kos_crypto::cipher;
 use kos_crypto::cipher::CipherAlgo;
 use kos_sdk::chain::Chain;
+use kos_sdk::chains::ETH;
 use kos_sdk::models::{PathOptions, Transaction};
 use kos_sdk::wallet::Wallet;
 use kos_types::error::Error as KosError;
@@ -66,6 +67,20 @@ fn sign_transaction(account: KOSAccount, raw: String) -> Result<KOSTransaction,
     })
 }
 
+#[uniffi::export]
+fn sign_typed_data_v4(account: KOSAccount, data: String) -> Result<Vec<u8>, KOSError> {
+    let chain = get_chain_by(account.chain_id)?;
+    if chain != Chain::ETH {
+        return Err(KOSError::UnsupportedChain {
+            id: account.chain_id.to_string(),
+        });
+    }
+    let wallet = Wallet::from_private_key(chain, account.private_key.to_string())?;
+    let keypair = wallet.get_keypair().unwrap();
+    let signature = ETH::sign_type_data_v4(&data, &keypair)?;
+    Ok(signature)
+}
+
 #[uniffi::export]
 fn generate_mnemonic(size: i32) -> Result<String, KOSError> {
     Ok(kos_crypto::mnemonic::generate_mnemonic(size as usize)?.to_phrase())
@@ -374,4 +389,61 @@ mod tests {
             "The signature doesn't match"
         );
     }
+
+    #[test]
+    fn should_sign_typed_data_v4() {
+        let chain_id = 3;
+        let data = r#"{
+            "types": {
+                "EIP712Domain": [
+                    { "name": "name", "type": "string" },
+                    { "name": "version", "type": "string" },
+                    { "name": "chainId", "type": "uint256" },
+                    { "name": "verifyingContract", "type": "address" }
+                ],
+                "Person": [
+                    { "name": "name", "type": "string" },
+                    { "name": "wallet", "type": "address" }
+                ],
+                "Mail": [
+                    { "name": "from", "type": "Person" },
+                    { "name": "to", "type": "Person" },
+                    { "name": "contents", "type": "string" }
+                ]
+            },
+            "primaryType": "Mail",
+            "domain": {
+                "name": "Ether Mail",
+                "version": "1",
+                "chainId": 1,
+                "verifyingContract": "0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC"
+            },
+            "message": {
+                "from": {
+                    "name": "Cow",
+                    "wallet": "0xCD2a3d9F938E13CD947Ec05AbC7FE734Df8DD826"
+                },
+                "to": {
+                    "name": "Bob",
+                    "wallet": "0xbBbBBBBbbBBBbbbBbbBbbbbBBbBbbbbBbBbbBBbB"
+                },
+                "contents": "Hello, Bob!"
+            }
+        }"#;
+        let account = generate_wallet_from_mnemonic(
+            "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about".to_string(),
+            chain_id,
+            0,
+            false
+        ).unwrap();
+
+        let signature = sign_typed_data_v4(account, data.to_string()).unwrap();
+
+        assert_eq!(signature.len(), 65, "The signature length doesn't match");
+
+        assert_eq!(
+            hex::encode(signature.clone()),
+            "5b9ee7ebad3acd6ca243732900203a8a9e59b871345cb9b229a1936e11f5ad8967c46a0d05027ccd880bcc49e18877a53b8e4813558a1fd165ebb875c4a447c201"
+        );
+    }
 }
diff --git a/packages/kos-sdk/src/chains/ethereum/mod.rs b/packages/kos-sdk/src/chains/ethereum/mod.rs
@@ -171,7 +171,7 @@ impl ETH {
         let typed_data: TypedData = serde_json::from_str(data)?;
         let digest = typed_data
             .eip712_signing_hash()
-            .map_err(|e| Error::InvalidMessage(format!("failed to sign typed data: {}", e)))?;
+            .map_err(|_e| Error::InvalidMessage("failed to sign typed data".to_string()))?;
         ETH::sign_digest(digest.as_slice(), keypair)
     }