Fix/cardano connect #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace ada folder to cardano since its the correct fullname of the network
connect method have some issues, try fixing and debug some through catch block
change used by unused addresses method for better privacy and avoid empty accounts bug
lucasportella
commented
Mar 4, 2024
| return usedAddresses | ||
| try { | ||
| const api = await web3Window.cardano[injectedWallet].enable() | ||
| const unusedAddresses: CardanoUnusedAddresses[] = await api.getUnusedAddresses() |
There was a problem hiding this comment.
changed to getUnusedAddresses method for enhanced privacy and avoid empty arrays from used Address throwing errors.
lucasportella
commented
Mar 4, 2024
| @@ -1,4 +1,4 @@ | |||
| export * from './ada/index' | |||
| export * from './cardano/index' | |||
There was a problem hiding this comment.
corrected network name, ada is the coin
fix conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task title
✨ Features:
🔨 Improvements: