Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: introduce yearly notes page #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpetrina
Copy link

@jpetrina jpetrina commented Feb 3, 2022

Perhaps adding a simple empty notes page might prove as an useful feature. Alternatively, I considered basing the notes page on the Monthly Overview, but it would probably require a new "month list" header subview.

What do you think?

This change adds a new blank page for writing yearly notes.

Signed-off-by: Jakov Petrina <[email protected]>
@klimeryk
Copy link
Owner

klimeryk commented Jul 9, 2022

👋 Thanks for the suggestion! Could you add more explanation how you'd use this page? Sort of setting goals for the year kind of thing? I'm honestly not that forward-thinking so I'd probably not use it, but I can definitely see it could benefit others.

@jpetrina
Copy link
Author

@klimeryk yes, that is exactly right.

Monthly overviews and a blank page for the year seem to work for me the best. I'm still considering weekly overviews as they seem to be fairly compact but day itineraries really overload me.

I suppose this could be feature-creep, but I'm hopeful it might be useful.

@ovidiusoft
Copy link

ovidiusoft commented May 28, 2023

@jpetrina I am having trouble with these changes. I tried to run them locally (both from this PR and from your original fork) and the generated PDF doesn't have a new page or a link to it, as the source code would suggest. Can you check if all the changes you intended made it into the PR? A screenshot of what the result would look like would be great as well, thank you!

Later edit: Nevermind, I managed to run from the wrong directory / my own branch, not from your changes 🤦 It works as expected, a blanc page appeared after the yearly calendar page, and is properly linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants