Use prefix instead of equal to handle 'resource(matcher)' types

klothoplatform · Feb 29, 2024 · 08667e7 · 08667e7
1 parent cd31f21
commit 08667e7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/pkg/engine/operational_eval/vertex_path_expand.go b/pkg/engine/operational_eval/vertex_path_expand.go
@@ -136,7 +136,7 @@ func (v *pathExpandVertex) addDepsFromProps(
 	var errs error
 	for k, prop := range tmpl.Properties {
 		// Only consider properties whose type can even accommodate a resource
-		if prop.Type() != "resource" {
+		if !strings.HasPrefix(prop.Type(), "resource") {
 			continue
 		}
 		details := prop.Details()

diff --git a/pkg/engine/operational_eval/vertex_path_expand_test.go b/pkg/engine/operational_eval/vertex_path_expand_test.go
@@ -154,6 +154,7 @@ func Test_pathExpandVertex_addDepsFromProps(t *testing.T) {
 
 				mockSol.On("RawView").Return(resultGraph).Once()
 				mockProperty.EXPECT().Validate(resource, construct.ResourceId{Name: "u"}, gomock.Any()).Return(nil).Times(1)
+				mockProperty.EXPECT().Type().Return("resource").Times(1)
 				return nil
 			},
 			want: graphChanges{

diff --git a/pkg/knowledgebase/properties/string_property_test.go b/pkg/knowledgebase/properties/string_property_test.go
@@ -235,13 +235,23 @@ func Test_StringParse(t *testing.T) {
 			expected: "test",
 		},
 		{
-			name: "non string throws error",
+			name: "non string converts int",
+			property: &StringProperty{
+				PropertyDetails: knowledgebase.PropertyDetails{
+					Path: "test",
+				},
+			},
+			value:    1,
+			expected: "1",
+		},
+		{
+			name: "non string fails non-primitive",
 			property: &StringProperty{
 				PropertyDetails: knowledgebase.PropertyDetails{
 					Path: "test",
 				},
 			},
-			value:   1,
+			value:   []string{"hi"},
 			wantErr: true,
 		},
 	}