dont check validity if theres already an edge (#822)

klothoplatform · Dec 12, 2023 · 1c0d9a1 · 1c0d9a1
1 parent dbc2f00
commit 1c0d9a1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/pkg/engine2/path_selection/path_expansion.go b/pkg/engine2/path_selection/path_expansion.go
@@ -437,11 +437,19 @@ func expandPath(
 			return
 		}
 
-		valid, err := checkUniquenessValidity(ctx, source.id, target.id)
-		if err != nil {
+		// if the edge doesnt exist in the actual graph we need to check uniqueness validity
+		_, err := ctx.RawView().Edge(source.id, target.id)
+		if errors.Is(err, graph.ErrEdgeNotFound) {
+			valid, err := checkUniquenessValidity(ctx, source.id, target.id)
+			if err != nil {
+				errs = errors.Join(errs, err)
+				return
+			}
+			if !valid {
+				return
+			}
+		} else if err != nil {
 			errs = errors.Join(errs, err)
-		}
-		if !valid {
 			return
 		}
 

diff --git a/pkg/engine2/testdata/k8s_api.expect.yaml b/pkg/engine2/testdata/k8s_api.expect.yaml
@@ -135,7 +135,6 @@ resources:
             Enabled: true
             HealthyThreshold: 5
             Interval: 30
-            Matcher: 200-299
             Protocol: TCP
             Timeout: 5
             UnhealthyThreshold: 2

diff --git a/pkg/templates/aws/resources/target_group.yaml b/pkg/templates/aws/resources/target_group.yaml
@@ -59,7 +59,6 @@ properties:
         default_value: 2
       Matcher:
         type: string
-        default_value: 200-299
   Arn:
     type: string
     configuration_disabled: true