Skip test instead of fail if pylsp is not found

klothoplatform · Mar 6, 2024 · 9df5166 · 9df5166
1 parent 2840a11
commit 9df5166
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/pkg/code/lsp.go b/pkg/code/lsp.go
@@ -32,6 +32,9 @@ func NewLSP(ctx context.Context, lspCmd string, cmdStderr io.Writer) (*LSP, erro
 	log := zap.L().Named(fmt.Sprintf("lsp/%s", lspCmd))
 
 	cmd := exec.CommandContext(ctx, lspCmd, "-vv")
+	if cmd.Err != nil {
+		return nil, fmt.Errorf("failed to create command: %w", cmd.Err)
+	}
 	send, err := cmd.StdinPipe()
 	if err != nil {
 		return nil, fmt.Errorf("failed to create stdin pipe: %w", err)

diff --git a/pkg/code/python/python_test.go b/pkg/code/python/python_test.go
@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"strings"
 	"testing"
@@ -103,6 +104,9 @@ func (tc testCase) TestConstraints(t *testing.T, input []byte) {
 		"test.py": &fstest.MapFile{Data: input},
 	}
 	actual, err := FindBoto3Constraints(context.Background(), files)
+	if errors.Is(err, exec.ErrNotFound) {
+		t.Skip("pylsp not found")
+	}
 	if err != nil {
 		t.Fatal(err)
 	}