Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix api gw dependencies #780

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix api gw dependencies #780

merged 2 commits into from
Nov 21, 2023

Conversation

jhsinger-klotho
Copy link
Contributor

fixes api gw deps

Standard checks

  • Unit tests: Any special considerations?
  • Docs: Do we need to update any docs, internal or public?
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

gordon-klotho
gordon-klotho approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@gordon-klotho gordon-klotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the leftover debug print

pkg/engine2/operational_rule/operational_rule.go Outdated
Comment on lines 25 to 27
if ctx.Data.Edge != nil && ctx.Data.Edge.Source.String() == "aws:api_deployment:rest_api_0:api_deployment-0" {
fmt.Println("here")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug

@jhsinger-klotho jhsinger-klotho merged commit 694e274 into main Nov 21, 2023
14 of 19 checks passed
@jhsinger-klotho jhsinger-klotho deleted the gw_dependencies branch November 21, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordon-klotho gordon-klotho gordon-klotho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhsinger-klotho @gordon-klotho