Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudfront gateway #781

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Cloudfront gateway #781

merged 7 commits into from
Nov 21, 2023

Conversation

gordon-klotho
Copy link
Contributor 

### Collecting test suite ❱ aws-3dntew ❱ /home/gordon/w/engine-e2e-tests/test_suites/aws ❱ Building release application for path /home/gordon/w/engine-e2e-tests/test_suites/aws ❱ Build test suite aws-3dntew ❱ Generate constraints ❱ Format constraints ❱ Run engine ❱ Create Pulumi stack ❱ Configuring stack ❱ Previewing stack aws-3dntew ❱ Deploying stack aws-3dntew to region us-east-2, attempt #0 ❱ Run tests
INFO:SuiteRunner:Test result for aws: name: aws
        result: Result.SUCCESS
eason: stdout:
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/gordon/w/engine-e2e-tests/output/aws-3dntew
plugins: xdist-3.4.0, html-4.1.1, repeat-0.9.3, anyio-3.7.1, metadata-3.0.0, check-2.2.2, asyncio-0.21.1
asyncio: mode=strict
created: 1/1 worker
1 worker [1 item]

.                                                                        [100%]
--------------------- generated xml file: /tmp/tmp6mp3bvka ---------------------
============================== 1 passed in 5.06s ===============================
[...]
2023-11-21 16:31:47,428 - DeploymentRunner - {/home/gordon/w/engine-e2e-tests/cli/commands/run.py:267} - INFO - Inspect output: file:///home/gordon/w/engine-e2e-tests/output/aws-3dntew
2023-11-21 16:31:47,429 - DeploymentRunner - {/home/gordon/w/engine-e2e-tests/cli/commands/run.py:268} - INFO - Inspect logs: file:///home/gordon/w/engine-e2e-tests/logs/3dntew
2023-11-21 16:31:47,430 - DeploymentRunner - {/home/gordon/w/engine-e2e-tests/cli/commands/run.py:135} - INFO - Result for _home_gordon_w_engine-e2e-tests_test_suites_aws: Result.SUCCESS
2023-11-21 16:31:47,430 - DeploymentRunner - {/home/gordon/w/engine-e2e-tests/cli/commands/run.py:135} - INFO - Result for aws-3dntew-destroy: Result.SUCCESS

jhsinger-klotho
jhsinger-klotho reviewed Nov 21, 2023
View reviewed changes
pkg/templates/aws/resources/s3_bucket.yaml
| replace `(^[.-]+)|([.-]+$)` ""
| replace `\.\.+` "."
| replace `^([0-9]+)\.([0-9]+)\.([0-9]+)` "$1-$2-$3"
| length 3 63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want length 55 for the iac suffix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that a pulumi-specific implementation detail?

@gordon-klotho gordon-klotho merged commit 49da588 into main Nov 21, 2023
81 checks passed
@gordon-klotho gordon-klotho deleted the cloudfront_gateway branch November 21, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhsinger-klotho jhsinger-klotho jhsinger-klotho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gordon-klotho @jhsinger-klotho