New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casing on app_runner environment variables #782

Merged

gordon-klotho merged 2 commits into main from app_runner

Nov 27, 2023

Contributor

gordon-klotho commented Nov 23, 2023

Added name sanitization to app_runner
Minor fixes/cleanup

Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?


          Fix casing on app_runner environment variables

7585b85

Added name sanitization to app_runner
Minor fixes/cleanup

jhsinger-klotho approved these changes

View reviewed changes


          Go back to using nil for missing properties for now

89c0ceb

gordon-klotho merged commit 53b65ee into main

80 checks passed

gordon-klotho deleted the app_runner branch

November 27, 2023 15:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet