add alb support #792
Merged
add alb support #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type: list(string) | ||
| Listener: | ||
| type: resource(aws:load_balancer_listener) | ||
| default_value: '{{ upstream "aws:load_balancer" .Self }}' |
There was a problem hiding this comment.
Wouldn't this make the default value the upstream load balancer rather than a listener?
There was a problem hiding this comment.
yeah, i didnt think i included this file since its not used yet, miss on my part
gordon-klotho
approved these changes
Nov 28, 2023
Comment on lines
4
to
8
| - configuration_rules: | ||
| - resource: '{{ .Source }}' | ||
| configuration: | ||
| field: Certificate | ||
| value: '{{ .Target }}' |
There was a problem hiding this comment.
Is it weird to have this as a edge config rule instead of an operational rule?
There was a problem hiding this comment.
can move it over
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for configuring load balancers as application load balancers
Standard checks