New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug with routes #816

Merged

jhsinger-klotho merged 1 commit into main from route_bug

Dec 11, 2023

Contributor

jhsinger-klotho commented Dec 11, 2023 •

edited

Loading

closes #814
method should be unique to the integration, we cant make it check the resource field because that wont exist for / route.

Naming needs to ensure there are no conflicts so we will make sure all resource names are different when we are responsible for naming

Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?


          fix bug with routes

f6307a2

gordon-klotho approved these changes

View reviewed changes

jhsinger-klotho merged commit 76e1fc7 into main

6 checks passed

jhsinger-klotho deleted the route_bug branch

December 11, 2023 16:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet